Make sure to clear the back stack after NameYourDevice is done #5912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoPtr
commented
Oct 10, 2025
Comment on lines
+372
to
+385
| @Test | ||
| fun `Given device named and skip welcome with url when pressing next then show LocalFirst then goes back stop the app`() { | ||
| localFirstTest(true, "http://ha.local") | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given device named and skip welcome without url when pressing next then show LocalFirst then goes back stop the app`() { | ||
| localFirstTest(true, null) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Given device named when pressing next then show LocalFirst then goes back stop the app`() { | ||
| val instanceUrl = "http://ha.local" | ||
| testNavigation { | ||
| navController.navigateToNameYourDevice(instanceUrl, "code") | ||
| localFirstTest(false, null) | ||
| } |
There was a problem hiding this comment.
@jpelgrom since this class is using JUnit 4 I can't use ParametrizedTest 👎🏻
There was a problem hiding this comment.
Thanks for the explanation. More specific test titles are good to have here anyway.
4 tasks
jpelgrom
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing the new onboading @klaasnicolaas found out that we can come back to name your device when adding a server from the settings. It put the apps in a weird state because the
auth_tokenis already consumed so we cannot do anything on this screen and it leads to this errorThis is due to the recent changes that skip the welcome screen, we were poping up up to WelcomeScreen but since we've skipped it the framework is not able to clear the back stack properly. This PR ensure that we clear up to the startDestination instead.
Checklist
Screenshots
Screen_recording_20251010_142557.mp4