hkr3d2
diff --git a/Collapse file
‎include/components.hpp‎
Copy file name to clipboardExpand all lines: include/components.hpp
+4Lines changed: 4 additions & 0 deletions b/Collapse file
‎include/components.hpp‎
Copy file name to clipboardExpand all lines: include/components.hpp
+4Lines changed: 4 additions & 0 deletions
diff --git a/Collapse file
‎include/config.hpp‎
Copy file name to clipboardExpand all lines: include/config.hpp
+11-8Lines changed: 11 additions & 8 deletions b/Collapse file
‎include/config.hpp‎
Copy file name to clipboardExpand all lines: include/config.hpp
+11-8Lines changed: 11 additions & 8 deletions
diff --git a/Collapse file
‎src/modules/api/events.cpp‎
Copy file name to clipboardExpand all lines: src/modules/api/events.cpp
+1Lines changed: 1 addition & 0 deletions b/Collapse file
‎src/modules/api/events.cpp‎
Copy file name to clipboardExpand all lines: src/modules/api/events.cpp
+1Lines changed: 1 addition & 0 deletions
@@ -159,6 +159,8 @@ namespace eclipse::events {
     };
 }
 
+#ifndef ECLIPSE_DONT_DEFINE_IMPLS
+
 namespace eclipse {
     /// @brief Get a menu tab handle by name. Creates the tab if it doesn't exist.
     /// @param name The name of the tab.
@@ -284,4 +286,6 @@ namespace eclipse {
     }
 }
 
+#endif // ECLIPSE_DONT_DEFINE_IMPLS
+
 #endif // ECLIPSE_COMPONENTS_HPP
@@ -22,7 +22,7 @@ namespace eclipse::events {
         explicit RequestConfigValueEvent(std::string key, bool internal = false)
             : m_key(std::move(key)), m_useInternal(internal) {}
         const std::string& getKey() const { return m_key; }
-        T getValue() const { return m_value; }
+        T&& getValue() { return std::move(m_value); }
         bool hasValue() const { return m_hasValue; }
         bool getUseInternal() const { return m_useInternal; }
 
@@ -42,10 +42,10 @@ namespace eclipse::events {
     class SetConfigValueEvent : public geode::Event {
     public:
         SetConfigValueEvent(std::string key, T value, bool internal = false)
-            : m_key(std::move(key)), m_value(value), m_useInternal(internal) {}
+            : m_key(std::move(key)), m_value(std::move(value)), m_useInternal(internal) {}
 
         std::string const& getKey() const { return m_key; }
-        T getValue() const { return m_value; }
+        T&& getValue() { return std::move(m_value); }
         bool getUseInternal() const { return m_useInternal; }
 
     private:
@@ -56,15 +56,16 @@ namespace eclipse::events {
 
 }
 
-namespace eclipse::config {
+#ifndef ECLIPSE_DONT_DEFINE_IMPLS
 
+namespace eclipse::config {
     /// @brief Get a config value by key from the session storage.
     /// @param key The key of the value.
     /// @param defaultValue The default value to return if the key doesn't exist.
     /// @return The value of the key or the default value if the key doesn't exist.
     template <SupportedType T>
     T get(std::string key, T defaultValue) {
-        events::RequestConfigValueEvent<T> event(key);
+        events::RequestConfigValueEvent<T> event(std::move(key));
         event.post();
         if (event.hasValue())
             return event.getValue();
@@ -77,7 +78,7 @@ namespace eclipse::config {
     /// @return The value of the key or the default value if the key doesn't exist.
     template <SupportedType T>
     T getInternal(std::string key, T defaultValue) {
-        events::RequestConfigValueEvent<T> event(key, true);
+        events::RequestConfigValueEvent<T> event(std::move(key), true);
         event.post();
         if (event.hasValue())
             return event.getValue();
@@ -89,16 +90,18 @@ namespace eclipse::config {
     /// @param value The value to set.
     template <SupportedType T>
     void set(std::string key, T value) {
-        events::SetConfigValueEvent<T>(key, value, false).post();
+        events::SetConfigValueEvent<T>(std::move(key), std::move(value), false).post();
     }
 
     /// @brief Set a config value by key in the persistent storage (config.json).
     /// @param key The key of the value.
     /// @param value The value to set.
     template <SupportedType T>
     void setInternal(std::string key, T value) {
-        events::SetConfigValueEvent<T>(key, value, true).post();
+        events::SetConfigValueEvent<T>(std::move(key), std::move(value), true).post();
     }
 }
 
+#endif // ECLIPSE_DONT_DEFINE_IMPLS
+
 #endif // ECLIPSE_CONFIG_HPP
@@ -1,3 +1,4 @@
+#define ECLIPSE_DONT_DEFINE_IMPLS
 #include <eclipse.hpp>
 #include <modules/config/config.hpp>
 #include <modules/gui/gui.hpp>
Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,8 @@ namespace eclipse::events {`
`159`	`159`	`};`
`160`	`160`	`}`
`161`	`161`
	`162`	`+#ifndef ECLIPSE_DONT_DEFINE_IMPLS`
	`163`	`+`
`162`	`164`	`namespace eclipse {`
`163`	`165`	`/// @brief Get a menu tab handle by name. Creates the tab if it doesn't exist.`
`164`	`166`	`/// @param name The name of the tab.`
`@@ -284,4 +286,6 @@ namespace eclipse {`
`284`	`286`	`}`
`285`	`287`	`}`
`286`	`288`
	`289`	`+#endif // ECLIPSE_DONT_DEFINE_IMPLS`
	`290`	`+`
`287`	`291`	`#endif // ECLIPSE_COMPONENTS_HPP`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#define ECLIPSE_DONT_DEFINE_IMPLS`
`1`	`2`	`#include <eclipse.hpp>`
`2`	`3`	`#include <modules/config/config.hpp>`
`3`	`4`	`#include <modules/gui/gui.hpp>`