Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: isLongZeroAddress for non-zero shards and realms #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
Loading
from
Open

fix: isLongZeroAddress for non-zero shards and realms #2298

wants to merge 10 commits into from

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Apr 15, 2025 •
edited by 0xivanov
Loading

Description:

Related issue(s):

Fixes #2300

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@naydenovn
chore: PoC for fromSolidityAddress fix
3c55693 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn naydenovn self-assigned this Apr 15, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../main/java/com/hedera/hashgraph/sdk/AccountId.java 50.00% 1 Missing and 2 partials ⚠️
...main/java/com/hedera/hashgraph/sdk/ContractId.java 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
.../java/com/hedera/hashgraph/sdk/EntityIdHelper.java 80.80% <100.00%> (ø) 40.00 <4.00> (?)
...main/java/com/hedera/hashgraph/sdk/ContractId.java 67.02% <0.00%> (ø) 32.00 <1.00> (?)
.../main/java/com/hedera/hashgraph/sdk/AccountId.java 74.40% <50.00%> (ø) 54.00 <4.00> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@naydenovn
chore: introduce new method for handling hieroAccountAddress
acdf749 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
chore: added functionality to contractId and also ome unit tests
c9ffebd 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
chore: introduce negative values handling for shards and realms
cdf8d7a 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
chore: spotlessApply
ac6cca1 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@0xivanov 0xivanov changed the title chore: PoC for fromSolidityAddress fix fix: isLongZeroAddress for non-zero shards and realms Apr 22, 2025
@0xivanov 0xivanov changed the title fix: isLongZeroAddress for non-zero shards and realms fix: isLongZeroAddress for non-zero shards and realms Apr 22, 2025
@0xivanov 0xivanov changed the title fix: isLongZeroAddress for non-zero shards and realms fix: isLongZeroAddress for non-zero shards and realms Apr 22, 2025
@naydenovn
chore: replace deprecated long zero method
5b4e832 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
Merge branch 'main' into fromSolidityAddress-PoC
0e0ed7e
@naydenovn
chore: add junit to testModuleInfo
367732e 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
chore: revert contractId changes
2183ac0 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn
chore: spotlessApply
b9adc3c 
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn naydenovn marked this pull request as ready for review May 8, 2025 14:10
@naydenovn naydenovn requested review from a team as code owners May 8, 2025 14:10
@naydenovn naydenovn requested review from nathanklick and 0xivanov May 8, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hiero-ledger/github-maintainers

@0xivanov 0xivanov Awaiting requested review from 0xivanov 0xivanov is a code owner automatically assigned from hiero-ledger/hiero-sdk-java-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@naydenovn naydenovn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix AccountId.fromSolidityAddress() to properly handle non-zero shard and realm values
1 participant
@naydenovn
Morty Proxy This is a proxified and sanitized view of the page, visit original site.