Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

HV-1429 Incorrect Pax URL syntax for paranamer #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tonit
Copy link
Contributor

@tonit tonit commented Jul 7, 2017

Incorrect Pax URL syntax for bundle (dependency) com.thoughtworks.paranamer/paranamer

Incorrect Pax URL syntax for bundle (dependency) com.thoughtworks.paranamer/paranamer
@Hibernate-CI
Copy link
Contributor

Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test")

@gsmet
Copy link
Member

gsmet commented Jul 7, 2017

@tonit Hi!

Thanks for your PR. Could you take the time to add a test in our OsgiIntegrationTest? It's apparently missing :).

And could you please sign the CLA for the Hibernate Validator project here: https://cla.jboss.org/ ?

Thanks!

This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf.
It highlights the issue found by hibernate#803 but should be extended whenever a new feature is being added to the repo.
@tonit
Copy link
Contributor Author

tonit commented Jul 7, 2017

I have just added tests for this. CLA will come..

@tonit
Copy link
Contributor Author

tonit commented Jul 7, 2017

CLA signed. (tonitcom)

gsmet pushed a commit that referenced this pull request Jul 7, 2017
This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf.
It highlights the issue found by #803 but should be extended whenever a new feature is being added to the repo.
gsmet pushed a commit that referenced this pull request Jul 7, 2017
This commit adds a new Pax Exam based test installing both karaf features provided by this project on a vanilla karaf.
It highlights the issue found by #803 but should be extended whenever a new feature is being added to the repo.
@gsmet
Copy link
Member

gsmet commented Jul 7, 2017

@tonit thanks! I amended the commit messages to include a JIRA issue number and made a few very minor improvements.

Merged to master and the 5.4 branch.

@gsmet gsmet closed this Jul 7, 2017
@gsmet gsmet changed the title Incorrect Pax URL syntax for paranamer HV-1429 Incorrect Pax URL syntax for paranamer Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.