Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix: resolve PHPCS coding standards violations in src folder.#9

Merged
fraggerfox merged 4 commits intodevhellocoop/php:devfrom
chore/phpcs-cleanuphellocoop/php:chore/phpcs-cleanupCopy head branch name to clipboard
Dec 18, 2024
Merged

fix: resolve PHPCS coding standards violations in src folder.#9
fraggerfox merged 4 commits intodevhellocoop/php:devfrom
chore/phpcs-cleanuphellocoop/php:chore/phpcs-cleanupCopy head branch name to clipboard

Conversation

@UnnikrishnanBhargavakurup
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Type/AuthUpdates.php 0.00% 10 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/Exception/CallbackException.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Exception/SameSiteCallbackException.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
src/Handler/Callback.php 66.66% <100.00%> (ø) 38.00 <4.00> (ø)
src/HelloClient.php 50.00% <ø> (ø) 25.00 <0.00> (ø)
src/Lib/PKCE.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Type/AuthCookie.php 100.00% <100.00%> (ø) 8.00 <8.00> (ø)
src/Type/Claims.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/Type/OIDC.php 88.88% <100.00%> (ø) 7.00 <7.00> (ø)
src/Type/AuthUpdates.php 0.00% <0.00%> (ø) 10.00 <10.00> (ø)

... and 1 file with indirect coverage changes

@fraggerfox fraggerfox merged commit 495ee8b into dev Dec 18, 2024
@fraggerfox fraggerfox deleted the chore/phpcs-cleanup branch December 18, 2024 19:35
UnnikrishnanBhargavakurup added a commit that referenced this pull request Dec 19, 2024
* Fix logout callback issue: Corrected callback from getLoginSync to getLogoutSync and updated unit test.

* fix: resolve PHPCS coding standards violations in src folder. (#9)

* fix: resolve PHPCS coding standards violations in src folder.

* fixed coding standard

* Added --exclude=Generic.Files.LineLength to composer configuration

* Fix deprecation in PHP 8.4: Explicitly mark parameters as nullables.

* Add missing configuration files for CI.

* Disable caching for phpcs.

* Fix the phpstan configuration.

---------

Co-authored-by: Unnikrishnan <unnikrishnanadoor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.