Remove the MINIMAL pragma from Pretty#219
Merged
sjakobi merged 1 commit intohaskell-prettyprinter:masterhaskell-prettyprinter/prettyprinter:masterfrom Jun 7, 2022
dwincort:no-minimal-pragma-issue-218dwincort/prettyprinter:no-minimal-pragma-issue-218Copy head branch name to clipboard
Merged
Remove the MINIMAL pragma from Pretty#219sjakobi merged 1 commit intohaskell-prettyprinter:masterhaskell-prettyprinter/prettyprinter:masterfrom dwincort:no-minimal-pragma-issue-218dwincort/prettyprinter:no-minimal-pragma-issue-218Copy head branch name to clipboard
Pretty#219sjakobi merged 1 commit intohaskell-prettyprinter:masterhaskell-prettyprinter/prettyprinter:masterfrom
dwincort:no-minimal-pragma-issue-218dwincort/prettyprinter:no-minimal-pragma-issue-218Copy head branch name to clipboard
Conversation
Collaborator
|
The build failure with GHC 7.4.2 is due to UnkindPartition/tasty#321. Unless that issue is resolved speedily, we can try to add to constraints locally to nudge |
sjakobi
approved these changes
Jan 4, 2022
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
Thanks!
The build is fixed.
Contributor
Author
|
Any thoughts on getting this merged and pushed to hackage? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #218.