Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@nataren
Copy link
Collaborator

@nataren nataren commented Aug 16, 2014

I am using the events API and noticed that we were missing some new data constructors so I added them.

I bumped the major version as per:

If any entity was removed, or the types of any entities or the definitions of datatypes or classes were changed, or orphan instances were added or any instances were removed, then the new A.B must be greater than the previous A.B. Note that modifying imports or depending on a newer version of another package may cause extra orphan instances to be exported and thus force a major version change.```
per [Haskell's Package Version Policy](http://www.haskell.org/haskellwiki/Package_versioning_policy).

@maxpow4h Good to go?

@mxswd
Copy link
Contributor

mxswd commented Aug 18, 2014

@nataren Yup! 👍

nataren added a commit that referenced this pull request Aug 18, 2014
@nataren nataren merged commit dfabb25 into haskell-github:master Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.