Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@pharpend
Copy link
Contributor

No description provided.

@hdgarrood
Copy link
Contributor

This will fail for base < 4.8. There's no need to use CPP - just do what I described in #99.

@pharpend
Copy link
Contributor Author

@hdgarrood Well, I did the CPP thing before I read your comment. The CPP thing works, I think. I don't understand your solution.

Edit: See my comment in #99

@pharpend
Copy link
Contributor Author

The tests pass, by the way.

@hdgarrood
Copy link
Contributor

Ohh, my bad - I guess the type declaration for whatever type defaultTimeLocale is must have been copied into time, not re-exported. 👍 for this then.

jwiegley added a commit that referenced this pull request Apr 26, 2015
@jwiegley jwiegley merged commit dc683fc into haskell-github:master Apr 26, 2015
@pharpend
Copy link
Contributor Author

@jwiegley

When are you planning on publishing a new version on Hackage?

The reason I ask is, snowdriftcoop/snowdrift#305 is dependent on you pushing a new version.

@jwiegley
Copy link
Contributor

In a few minutes. :)

@jwiegley
Copy link
Contributor

Just waiting on the latest Nix changes to build so that I can test it.

@pharpend
Copy link
Contributor Author

Ah alright. Thank you!

@jwiegley
Copy link
Contributor

@pharpend Uploaded to Hackage as 0.13.2

@pharpend pharpend deleted the base-4.8 branch April 26, 2015 20:45
@pharpend
Copy link
Contributor Author

Thank you, jwiegley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.