Showcase: convert Modal to gts #3300
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@alex-ju I did a review, and for me everything seems fine, apart from the |
There was a problem hiding this comment.
For the abstraction.... Personally I would prefer a wrapper that handles the button and isOpen state. It could yield the header/body/footer.
We do something similar with Form inputs where we want to customize the character count: https://github.com/hashicorp/design-system/blob/main/showcase/app/components/page-components/form/text-input/code-fragments/with-character-count.gts
| import { COLORS } from '@hashicorp/design-system-components/components/hds/modal/index'; | ||
| import { NAMES as ICON_NAMES } from '@hashicorp/design-system-components/components/hds/icon/index'; | ||
|
|
||
| // Static color to icon mapping, same as in controller |
There was a problem hiding this comment.
| // Static color to icon mapping, same as in controller | |
| // Static color to icon mapping |
| superSelectOptions3 = ['Option 1', 'Option 2', 'Option 3']; | ||
| superSelectSelectedOption3 = this.superSelectOptions3[0]; | ||
|
|
||
| @action |
There was a problem hiding this comment.
Issue: you don't need to use @action anymore, they can just be arrow functions.
| } | ||
|
|
||
| @action | ||
| noop() { |
There was a problem hiding this comment.
Issue: you can use import NOOP from 'showcase/utils/noop' instead
📌 Summary
Converting the Modal examples page to gts. Still in two minds about the best way to align it to other examples using
code-fragmentsabstraction – feedback welcome.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-5346
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.