Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Showcase: cleanup work from converting routes to gts #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 14, 2025
Merged

Showcase: cleanup work from converting routes to gts #3296

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e2f66ca
feat: convert Application template to gts
Oct 10, 2025
7240e81
feat: convert index template to gts
Oct 10, 2025
b8a992f
chore: fix model-from-route file name
Oct 10, 2025
1c18ee8
chore: standardize style modifier imports
Oct 10, 2025
97afaf1
chore: delete controllers that got missed earlier
Oct 10, 2025
3776998
chore: delete route files for routes that dont exist
Oct 10, 2025
9f9010c
fix: replace mock state classes
Oct 13, 2025
ce457ce
fix: put modifier back in
Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Example file:
```ts
import Route from '@ember/routing/route';
import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';
export type PageComponentsAccordionModel =
ModelFrom<PageComponentsAccordionRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/mock/app/main/generic-form/partials/add-policy.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
// types
import type { HdsFormHeaderSignature } from '@hashicorp/design-system-components/components/hds/form/header/index';
import type { HdsFormSectionSignature } from '@hashicorp/design-system-components/components/hds/form/section/index';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

export interface MockAppMainGenericFormPartialsAddPolicySignature {
Args: {
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/mock/app/sidebar/app-side-nav.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import Component from '@glimmer/component';
import { tracked } from '@glimmer/tracking';
import { on } from '@ember/modifier';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

// HDS components
import {
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/advanced-table/sub-sections/base-elements.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MPL-2.0
*/
import Component from '@glimmer/component';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';
import { array, get } from '@ember/helper';
import { capitalize } from '@ember/string';
import type Owner from '@ember/owner';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/application-state/sub-sections/container.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import { on } from '@ember/modifier';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwFlex from 'showcase/components/shw/flex';
import ShwTextH2 from 'showcase/components/shw/text/h2';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/application-state/sub-sections/responsiveness.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import { array, hash } from '@ember/helper';
import { on } from '@ember/modifier';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwTextH2 from 'showcase/components/shw/text/h2';
import ShwDivider from 'showcase/components/shw/divider';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/badge-count/sub-sections/variants.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import type { TemplateOnlyComponent } from '@ember/component/template-only';
import { capitalize } from '@ember/string';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwFlex from 'showcase/components/shw/flex';
import ShwGrid from 'showcase/components/shw/grid';
Expand Down
2 changes: 1 addition & 1 deletion 2 ...omponents/page-components/form/key-value-inputs/code-fragments/with-demo-instructions.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';
import { eq } from 'ember-truth-helpers';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwTextH4 from 'showcase/components/shw/text/h4';
import ShwLabel from 'showcase/components/shw/label';
Expand Down
2 changes: 1 addition & 1 deletion 2 ...p/components/page-components/form/key-value-inputs/code-fragments/with-dynamic-inputs.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { on } from '@ember/modifier';
import { tracked } from '@glimmer/tracking';
import { deepTracked } from 'ember-deep-tracked';
import { eq, or } from 'ember-truth-helpers';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import CodeFragmentWithDemoInstructions from 'showcase/components/page-components/form/key-value-inputs/code-fragments/with-demo-instructions';

Expand Down
2 changes: 1 addition & 1 deletion 2 ...onents/page-components/form/key-value-inputs/code-fragments/with-validation-and-limit.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { on } from '@ember/modifier';
import { tracked } from '@glimmer/tracking';
import { deepTracked } from 'ember-deep-tracked';
import { or } from 'ember-truth-helpers';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import CodeFragmentWithDemoInstructions from 'showcase/components/page-components/form/key-value-inputs/code-fragments/with-demo-instructions';

Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/icon/sub-sections/color.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';

import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwTextH2 from 'showcase/components/shw/text/h2';
import ShwTextH4 from 'showcase/components/shw/text/h4';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/icon/sub-sections/size.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';

import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwTextH2 from 'showcase/components/shw/text/h2';
import ShwTextBody from 'showcase/components/shw/text/body';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/tag/sub-sections/containers.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MPL-2.0
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';
import { array } from '@ember/helper';

import ShwTextH2 from 'showcase/components/shw/text/h2';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/tag/sub-sections/link-colors.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MPL-2.0
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';
import { capitalize } from '@ember/string';

import ShwTextH2 from 'showcase/components/shw/text/h2';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-components/tag/sub-sections/states.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MPL-2.0
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';
import { capitalize } from '@ember/string';

import ShwTextH2 from 'showcase/components/shw/text/h2';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-foundations/focus-ring/sub-sections/base.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MPL-2.0
*/
import type { TemplateOnlyComponent } from '@ember/component/template-only';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';

import ShwTextH2 from 'showcase/components/shw/text/h2';
import ShwFlex from 'showcase/components/shw/flex';
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/components/page-layouts/app-frame/sub-sections/3d-visualization.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Component from '@glimmer/component';
import { on } from '@ember/modifier';
import style from 'ember-style-modifier/modifiers/style';
import style from 'ember-style-modifier';
import { tracked } from '@glimmer/tracking';

import ShwTextH3 from 'showcase/components/shw/text/h3';
Expand Down
29 changes: 0 additions & 29 deletions 29 showcase/app/controllers/application.ts
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions 44 showcase/app/controllers/page-components.ts
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions 20 showcase/app/controllers/page-components/form/file-input.ts
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions 16 showcase/app/controllers/page-components/tag.ts
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions 46 showcase/app/controllers/page-utilities.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-layouts.ts → showcase/app/routes/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@

import Route from '@ember/routing/route';

export default class PageLayoutsRoute extends Route {}
export default class IndexRoute extends Route {}
8 changes: 0 additions & 8 deletions 8 showcase/app/routes/page-components.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/accordion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsAccordionModel =
ModelFrom<PageComponentsAccordionRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/advanced-table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsAdvancedTableModel =
ModelFrom<PageComponentsAdvancedTableRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsAlertModel = ModelFrom<PageComponentsAlertRoute>;

Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/app-footer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Route from '@ember/routing/route';

import { STATUSES as STATUS_LINK_STATUSES } from '@hashicorp/design-system-components/components/hds/app-footer/status-link';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsAppFooterModel =
ModelFrom<PageComponentsAppFooterRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/app-header/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsAppHeaderModel =
ModelFrom<PageComponentsAppHeaderRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/app-side-nav/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type ComponentsAppSideNavModel = ModelFrom<ComponentsAppSideNavRoute>;

Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/badge-count.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsBadgeCountModel =
ModelFrom<PageComponentsBadgeCountRoute>;
Expand Down
2 changes: 1 addition & 1 deletion 2 showcase/app/routes/page-components/badge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import Route from '@ember/routing/route';

import type { ModelFrom } from 'showcase/utils/ModelFromRoute';
import type { ModelFrom } from 'showcase/utils/model-from-route';

export type PageComponentsBadgeModel = ModelFrom<PageComponentsBadgeRoute>;

Expand Down
Loading
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.