-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Normalize out resource type names into new hfj_resource_type table #6890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize out resource type names into new hfj_resource_type table #6890
Conversation
Formatting check succeeded! |
Formatting check succeeded! |
Formatting check succeeded! |
…ormalize-out-resource-type-names-into-new-hfj_resource_type-table
Formatting check succeeded! |
Formatting check succeeded! |
…resource-type-names-into-new-hfj_resource_type-table
Formatting check succeeded! |
…resource-type-names-into-new-hfj_resource_type-table
This Pull Request has failed the formatting check Please run You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling |
Formatting check succeeded! |
Formatting check succeeded! |
Formatting check succeeded! |
This Pull Request has failed the formatting check Please run You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling |
Formatting check succeeded! |
Formatting check succeeded! |
…resource-type-names-into-new-hfj_resource_type-table # Conflicts: # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
Formatting check succeeded! |
Formatting check succeeded! |
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6890 +/- ##
============================================
- Coverage 83.41% 83.40% -0.01%
- Complexity 29193 29243 +50
============================================
Files 1843 1846 +3
Lines 113422 113658 +236
Branches 14251 14262 +11
============================================
+ Hits 94608 94801 +193
- Misses 12730 12764 +34
- Partials 6084 6093 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/cache/IResourceTypeCacheSvc.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/cache/ResourceTypeCacheSvcImpl.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/cache/ResourceTypeCacheSvcImpl.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/config/HapiFhirHibernateJpaDialect.java
Outdated
Show resolved
Hide resolved
...ir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceHistoryTag.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceLink.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTag.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTypeEntity.java
Show resolved
Hide resolved
…resource-type-names-into-new-hfj_resource_type-table
[spotless]: Formatting check succeeded! |
…resource-type-names-into-new-hfj_resource_type-table
[spotless]: Formatting check succeeded! |
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/cache/ResourceTypeCacheSvcImpl.java
Outdated
Show resolved
Hide resolved
[spotless]: This Pull Request has failed the formatting check Please run You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling |
[spotless]: Formatting check succeeded! |
Introduce a new hfj_resource_type table to normalize out the resource type name. These can be quite long (e.g. ExplanationOfBenefit is 20 bytes). These make for expensive indices. It increases the storage burden, and reduces performance.
This will be a 3 part migration, with each step 2 releases apart.
This ticket will only implement step 1.
Implementation
Closes #6889