Switch build to Vite, start adding types #3600
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d367c90 to
3704da2
Compare
|
I'm excited for this to come out 👍🏾 |
|
looking forward to this! |
|
@hakimel Any updates on the vite integration? |
The switch to Vite is done. Just needs more testing. The main task that remains in this branch is adding types. I'm not switching the whole source over to TS, but I want to distribute types with the reveal.js package. Types for reveal.js have already been written by multiple contributors over at DefinitelyTyped/DefinitelyTyped/tree/master/types/reveal.js. My plan is to move those types into the reveal.js codebase as a starting point and continue to maintain them there. That way the types will always be in sync with the rest of the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reveal.js is switching build systems from Gulp to Vite.
Vite is more actively maintained and has a great ecosystem of plugins. As part of this switch I'm also starting to migrate parts of the codebase to TS. For starters, I'll make sure we provide types for the reveal.js config object and API.
TODO
This is far from complete but opening a PR in case anyone has any input to share.