fix navigateNext to start at top of next vertical stack #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably the same fix needs to be applied one "else if" block above for config.rtl and so replacing the simple navigateLeft() there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some navigation issue regarding remembered vertical positions drove me crazy until I found out some details now.
After navigating left/right between vertical stacks below the top position and then continuing the presentation with Next (space or N) the presentation jumps from the bottom of current stack to the remembered position of the next stack to the right. And NOT to the top position as expected in the normal flow.
Navigating backwards (shift-space or P) is working correctly: The bottom slide of the next stack to the left is jumped to.
As far as I understand it the exact same behaviour is described in the older issue #2838.
So I fixed it in this PR.
(And I learned about npm etc. so that I was able to build reveal.js' "dist" directory.)