Replace deprecated Buffer constructor #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated Buffer constructor has been replaced with `Buffer.from` and `Buffer.alloc`. This removes deprecation warnings when this library is used. There were some instances where either the Buffer constructor or `Buffer.from` was used, depending on whether `Buffer.from` was defined. But this was unnecessary because the `engines` field of this package ensures that the minimum Node.js version used is 6, which includes the `Buffer.from` method.
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 10, 2021
The warnings about use of the unsafe Buffer constructor have been addressed by package updates and patches. The updates were: * `gulp-sourcemaps` was updated from v2 to v3, and was patched to replace remaining uses of the `Buffer` constructor * Upstream PR: gulp-sourcemaps/gulp-sourcemaps#388 * The transitive dependency `yazl` was updated from v2.4.3 to v2.5.1 in the lockfile. * The abandoned packages `combine-source-map` and `inline-source-map` were patched.
Gudahtt
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 27, 2021
The warnings about use of the unsafe Buffer constructor have been addressed by package updates and patches. The updates were: * `gulp-sourcemaps` was updated from v2 to v3, and was patched to replace remaining uses of the `Buffer` constructor * Upstream PR: gulp-sourcemaps/gulp-sourcemaps#388 * The transitive dependency `yazl` was updated from v2.4.3 to v2.5.1 in the lockfile. * The abandoned packages `combine-source-map` and `inline-source-map` were patched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated Buffer constructor has been replaced with
Buffer.fromandBuffer.alloc. This removes deprecation warnings when this library is used.There were some instances where either the Buffer constructor or
Buffer.fromwas used, depending on whetherBuffer.fromwas defined. But this was unnecessary because theenginesfield of this package ensures that the minimum Node.js version used is 6, which includes theBuffer.frommethod.