Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3f95f04

Browse filesBrowse files
authored
Merge pull request plotly#3122 from plotly/3121-fix-diff-config
ignore private attributes in diffConfig
2 parents 435a656 + 17252a8 commit 3f95f04
Copy full SHA for 3f95f04

File tree

2 files changed

+2
-1
lines changed
Filter options

2 files changed

+2
-1
lines changed

‎src/plot_api/plot_api.js

Copy file name to clipboardExpand all lines: src/plot_api/plot_api.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2641,6 +2641,7 @@ function diffConfig(oldConfig, newConfig) {
26412641
var key;
26422642

26432643
for(key in oldConfig) {
2644+
if(key.charAt(0) === '_') continue;
26442645
var oldVal = oldConfig[key];
26452646
var newVal = newConfig[key];
26462647
if(oldVal !== newVal) {

‎test/jasmine/assets/mock_lists.js

Copy file name to clipboardExpand all lines: test/jasmine/assets/mock_lists.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ var svgMockList = [
99
['17', require('@mocks/17.json')],
1010
['21', require('@mocks/21.json')],
1111
['22', require('@mocks/22.json')],
12-
['airfoil', require('@mocks/airfoil.json')],
12+
['airfoil', require('@mocks/airfoil.json')], // important to keep because it's the only mock with config options
1313
['annotations-autorange', require('@mocks/annotations-autorange.json')],
1414
['axes_enumerated_ticks', require('@mocks/axes_enumerated_ticks.json')],
1515
['axes_visible-false', require('@mocks/axes_visible-false.json')],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.