gregjones · domenicrosati · Jun 19, 2019 · Jun 20, 2019 · CAFxX · Feb 1, 2022
diff --git a/httpcache.go b/httpcache.go
@@ -192,11 +192,15 @@ func (t *Transport) RoundTrip(req *http.Request) (resp *http.Response, err error
 			for _, header := range endToEndHeaders {
 				cachedResp.Header[header] = resp.Header[header]
 			}
+			resp.Body.Close()
 			resp = cachedResp
 		} else if (err != nil || (cachedResp != nil && resp.StatusCode >= 500)) &&
 			req.Method == "GET" && canStaleOnError(cachedResp.Header, req.Header) {
 			// In case of transport failure and stale-if-error activated, returns cached content
 			// when available
+			if resp != nil && resp.Body != nil {
+				resp.Body.Close()
+			}
 			return cachedResp, nil
 		} else {
 			if err != nil || resp.StatusCode != http.StatusOK {
-Original file line number
+Diff line change
@@ -192,11 +192,15 @@ func (t *Transport) RoundTrip(req *http.Request) (resp *http.Response, err error
     			for _, header := range endToEndHeaders {
     				cachedResp.Header[header] = resp.Header[header]
     			}
+    			resp.Body.Close()
         Comment thread


        

        
      

        
          


  
    
        
        
  
    
      
          
    
  


        
            
  
      
              Copy link

  
              
  
      
                Copy Markdown

  
        
      
    

    
        



        

    
  

  
    
      
          
      

      
            CAFxX
  

      

      

      


        Feb 1, 2022


      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      it would be ideal to do
io.Copy(io.Discard, resp.Body)
resp.Body.Close()
so that the HTTP connection can also be reused
(same below)
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
              
  
    
    
      
        
            
    All reactions
     			resp = cachedResp
     		} else if (err != nil || (cachedResp != nil && resp.StatusCode >= 500)) &&
     			req.Method == "GET" && canStaleOnError(cachedResp.Header, req.Header) {
     			// In case of transport failure and stale-if-error activated, returns cached content
     			// when available
+    			if resp != nil && resp.Body != nil {
+    				resp.Body.Close()
+    			}
     			return cachedResp, nil
     		} else {
     			if err != nil || resp.StatusCode != http.StatusOK {
-          Expand Down