Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: prevent duplicate CI runs #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
Loading
from
Open

chore: prevent duplicate CI runs #117

wants to merge 2 commits into from

Conversation

kiendang
Copy link
Collaborator

@kiendang kiendang commented Aug 5, 2023

We have this in our workflows

on: [push, pull_request]

This is redundant since when someone pushes to a PR branch, it triggers both push and pull_request synchronized which makes the action runs twice. Checking every PR CI and you will see we have the every check run twice (push) and (pull_request).

Just on: push is enough.

@kiendang kiendang requested a review from erikwrede August 5, 2023 16:52
erikwrede
erikwrede reviewed Aug 5, 2023
View reviewed changes
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, the push condition does not apply to forks - that's why the PR trigger is necessary. Setting push to branch Master only should do the trick 😊

@kiendang kiendang mentioned this pull request Aug 5, 2023
Closed
@kiendang
Copy link
Collaborator Author

kiendang commented Aug 5, 2023

Yup that makes perfect sense.

@kiendang kiendang mentioned this pull request Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede left review comments

@cc-jj cc-jj cc-jj approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiendang @erikwrede @cc-jj
Morty Proxy This is a proxified and sanitized view of the page, visit original site.