Cancel remaining fields on exceptions #238
Conversation
|
Thank you @mgorven - will have a look later this week or on the weekend. |
CodSpeed Performance ReportMerging #238 will not alter performanceComparing Summary
|
322f5f6 to
6456782
Compare
|
Check is failing because coverage is not 100%, but this is because |
There was a problem hiding this comment.
Thanks a lot for this contribution and sorry for not looking into it earlier.
Your approach looks good to me, just a few suggestions.
Also, I think we need to do something similar in other places where we gather results asynchronously, e.g. in complete_list_value(). Let me know if you want to add it to this PR or create a separate one, or whether I should work on this.
gather() returns when the first exception is raised, but does not cancel any remaining tasks. These continue to run which is inefficient, and can also cause problems if they access shared resources like database connections. Fixes: graphql-python#236
|
Thanks for the review, I've addressed the comments. You can take the other instances, unless you aren't able to get to that for a while in which case I can help. |
gather() returns when the first exception is raised, but does not cancel any remaining tasks. These continue to run which is inefficient, and can also cause problems if they access shared resources like database connections.
Fixes: #236