A better ideal world of naming would have

DataLoaderOptions options = DataLoaderOptions.newOptions().setFutureCachingEnabled(false).setValueCache(myValueCache);

but backwards compatibility matters

Hi @bbakerman 👋 I had tried this out locally, and it seemed like setCachingEnabled(false) also disabled the ValueCache.

When I set up my DataLoader with this configuration, breakpoints set in MemcachedValueCache never got hit:

    return RegisteredLoader.builder()
        .name(EditorialQualityScoreLoader.NAME)
        .dataLoader(
            DataLoaderFactory.newMappedDataLoader(
                new MyLoader(myClient),
                DataLoaderOptions.newOptions()
                    .setCachingEnabled(false)
                    .setValueCache(
                        new MemcachedValueCache<>(
                            memcacheClient, EditorialQualityScores.class, getTtl(environment)))
                    .setMaxBatchSize(MAX_BATCH_SIZE)))
        .build();

However, I did manage to find a workaround, by setting the CacheMap to this NoopCacheMap:

public class NoopCacheMap<K, V> extends DefaultCacheMap<K, V> {
  @Override
  public boolean containsKey(Object key) {
    return false;
  }
}

Could it be that I got something wrong in my MemcachedValueCache implementation or that it needs to be implemented using Try for improved invalidation?

I was doing a code inspection to work out the "disabled" ness - its possible there is more logic controlling it.

I would need to do a reproduction test case - which I didnt do - to confirm.