Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Retain trivial DataFetcher marker when original DataFetcher was trivial#88

Merged
bbakerman merged 1 commit intographql-java:mastergraphql-java/graphql-java-extended-validation:masterfrom
mushipeas:fix/retain-datafetcher-trivial-marker-if-present-on-originalmushipeas/graphql-java-extended-validation:fix/retain-datafetcher-trivial-marker-if-present-on-originalCopy head branch name to clipboard
Aug 24, 2023
Merged

Retain trivial DataFetcher marker when original DataFetcher was trivial#88
bbakerman merged 1 commit intographql-java:mastergraphql-java/graphql-java-extended-validation:masterfrom
mushipeas:fix/retain-datafetcher-trivial-marker-if-present-on-originalmushipeas/graphql-java-extended-validation:fix/retain-datafetcher-trivial-marker-if-present-on-originalCopy head branch name to clipboard

Conversation

@mushipeas
Copy link
Contributor

@mushipeas mushipeas commented Jul 15, 2023

Resolve #87 - Create a TrivialFieldValidatorDataFetcher which extends FieldValidatorDataFetcher and implements TrivialDataFetcher instead of a standard FieldValidatorDataFetcher if the original dataFetcher was an instance of TrivialDataFetcher.

Create a TrivialFieldValidatorDataFetcher which implements TrivialDataFetcher instead of a standard FieldValidatorDataFetcher if the original dataFetcher was an instance of TrivialDataFetcher.
@mushipeas mushipeas changed the title Resolve #87 - Retain trivial DataFetcher marker when original DataFetcher was trivial Retain trivial DataFetcher marker when original DataFetcher was trivial Jul 15, 2023
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR

@bbakerman bbakerman merged commit 34df7d3 into graphql-java:master Aug 24, 2023
@mushipeas
Copy link
Contributor Author

And thank you for merging. 🥳

@mushipeas mushipeas deleted the fix/retain-datafetcher-trivial-marker-if-present-on-original branch August 25, 2023 01:30
@mushipeas mushipeas restored the fix/retain-datafetcher-trivial-marker-if-present-on-original branch August 25, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new dataFetcher created does not respect the original dataFetcher's trivial marker.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.