Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Introduce a GraphqlErrorException for Kotlin users and generally. #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbakerman merged 3 commits into from
Jan 17, 2020
Merged

Introduce a GraphqlErrorException for Kotlin users and generally. #1743

bbakerman merged 3 commits into from
Jan 17, 2020

Conversation

@bbakerman
Copy link
Member

@bbakerman bbakerman commented Jan 15, 2020

This is useful for error specialisations as well addressing as #1690

I am still waiting on Kotlin experts on why this helps

@bbakerman bbakerman added this to the 14.0 milestone Jan 15, 2020
@bbakerman bbakerman requested a review from andimarek January 15, 2020 12:31
@bbakerman
Copy link
Member Author

bbakerman commented Jan 17, 2020 •
edited
Loading

To use this in kotlin one would do

class MyException(message: String?, val extraProps: String) :
    GraphqlErrorException(newErrorException().message(message)) {

    override val message: String?
        get() {
            return "special code here : " + super.message
        }
}

That is this has extra properties AND if you really wanted to override the getMessage method in GraphqlError and the magic message property in Kotlin Throwable

@bbakerman bbakerman merged commit 578985f into master Jan 17, 2020
@andimarek andimarek mentioned this pull request Jan 19, 2020
Closed
@andimarek andimarek deleted the graphql-error-exception branch June 5, 2020 10:43
@Satook Satook mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek Awaiting requested review from andimarek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bbakerman
Morty Proxy This is a proxified and sanitized view of the page, visit original site.