Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bug: Subscription Message Serialziation #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

kevin-carroll
Copy link
Member

@kevin-carroll kevin-carroll commented Apr 20, 2025

Bug Fix - Subscription Messages

  • Fixed an bug with Id values being transmitted with a null value on non-specialized subscription messages.
  • Added unit tests to ensure non-existent id value on ACK messages for both protocols.

Infrastructure

  • Advanced github action build version of Ubuntu to latest (24.04)

Closes: #168

Fixed an issue with ID values being transmitted with a null value on non-specialized subscription messages.
@graphql-aspnet-owner
Copy link

graphql-aspnet-owner commented Apr 22, 2025

Code looks good. Did a smoke test, verified unit tests pass, ran all the demo projects with clean results. Need to download and verify against the new SS demo PR, then we'll be good.

@kevin-carroll kevin-carroll merged commit 54a16aa into master Apr 25, 2025
1 check passed
@kevin-carroll kevin-carroll deleted the bugs/168-erroneous-sub-message-id branch April 25, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription not working: connection_ack sent with null ID
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.