Fix test server build race condition (#134) #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aspnet#134 * Added graphql-aspnet-testframework-tests project with TestServerBuilderTests
…raphql-aspnet#134) * Ensure the SchemaItemPath.EnsurePathInitialized() method is only setting _pathInitialized when path is fully initialized.
|
great catch! Thank you for the PR. |
kevin-carroll
requested changes
Nov 10, 2023
|
See linting issues on the failed test run. There is a powershell script |
|
Thanks for the suggestions. Linting errors should be fixed, although I am unsure if git catches adding the BOM. |
kevin-carroll
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-aspnet-testframework-testsforGraphQL.AspNet.TestFrameworkwith a test case.SchemaItemPath.EnsurePathInitialized()method.Let me know if you would rather not have a test project for the test framework, and I'll remove it from the PR.