-
Notifications
You must be signed in to change notification settings - Fork 2k
Remove CJS from docs #4400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CJS from docs #4400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent; good riddance CJS! Should we add text to the intro saying you should be using an up to date version of Node 20, 22 or higher?
65ea2ef
to
9c1a829
Compare
0b7fa31
to
5d73bea
Compare
Is this just a doc change or are future versions of |
@glasser I think with Node 20 and 22 now supporting |
@benjie I'm currently working on Apollo Server 5, a release that is focused entirely on updating dependencies (Node, Express, GraphQL-JS). A goal is to have a really simple migration that most people can implement quickly. We are considering making it require GraphQL v17, depending on whether v17 is likely to actually be released soon and how hard the migration will be. If it's not just a matter of updating uses of obscure GraphQL-JS features but actually changing your build system, that's definitely a bit more intimidating for an upgrade, which makes me feel more like we should make AS5 continue to support v16 as well... we'd like there to be no good reason not to do the AS4 to AS5 upgrade as soon as possible. That said I'm a bit out of date on CJS vs ESM these days and maybe with |
|
No description provided.