This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Flush profiles rowgroup asynchronously #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed in dev for an hour or so |
Do you have a stack trace of the race? I'd like to look into it |
It's not really a race per say, but remove https://github.com/grafana/phlare/pull/760/files#diff-0db51ea7d6410dc44713dbafff69e0b0fe2c41b106f762be6dd039b3a984b719R367-R373 and run the tests it will fail from time to time or all the time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes flushing row groups of profiles asynchronously and outside of the read path.
Only one flushing can happen at once. This should drastically reduce the tail latency.
While working on this I realised we have a race between queries getting queriers (head and disk) and flushing row groups
I believe this could be the source of:
I decided to not fix this in this PR as it requires a larger refactoring.