Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Conversation

kolesnikovae
Copy link
Contributor

@kolesnikovae kolesnikovae commented Jun 5, 2023

The PR causes profile store to release profile objects when a new row group is flushed on disk. Currently, objects remain in memory and are not eligible for garbage collection.

Memory consumption of the ingester service has a rather interesting pattern:

Heap In-use (as reported by pprof):
image

In-use objects:
image

Where a half of the capacity is taken by convertSamples
image

Notice that once a new head is created, memory consumption goes to zero and then grows to ~50% of the max within the next 15-20 minutes. Supposedly, the trend indicates how samples are accumulated. However, I find it interesting that there's another "half": main contributors here are the stacktraces in-memory slice and in-memory parquet readers (that is not supposed to occupy so much memory as it only reads locations, strings, mappings, functions). Nevertheless, this is a different issue we may want to look into

@kolesnikovae kolesnikovae marked this pull request as ready for review June 5, 2023 10:57
Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch 👍

LGTM

@kolesnikovae kolesnikovae merged commit 50a6d5e into main Jun 5, 2023
@kolesnikovae kolesnikovae deleted the perf/profile-store-free-objects branch June 5, 2023 15:32
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.