Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

fix: filter out labelsset without the required labels instead of crashing #725

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: filter out labelsset without the required labels instead of crashing #725

merged 1 commit into from
May 30, 2023

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented May 30, 2023 •
edited
Loading

Apparently it's possible to have labelSets that don't have neither pyroscope_app nor service_name
image (7)

@eh-am eh-am marked this pull request as ready for review May 30, 2023 16:48
@eh-am eh-am changed the title fix: filter out labelsset without the required labels instead of cras… fix: filter out labelsset without the required labels instead of crashing May 30, 2023
Rperry2174
Rperry2174 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eh-am eh-am merged commit 49e4451 into main May 30, 2023
@eh-am eh-am deleted the fix/filter-out-labelsset-without-required-labels branch May 30, 2023 16:50
@eh-am eh-am mentioned this pull request Jul 19, 2023
Open
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@eh-am
fix: filter out labelsset without the required labels instead of cras…
2233957 
…hing (grafana/phlare#725)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Rperry2174 Rperry2174 Rperry2174 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eh-am @Rperry2174
Morty Proxy This is a proxified and sanitized view of the page, visit original site.