Require either DISPLAY or WAYLAND_DISPLAY being set#984
Merged
auouymous merged 1 commit intogpodder:mastergpodder/gpodder:masterfrom Mar 19, 2021
Merged
Require either DISPLAY or WAYLAND_DISPLAY being set#984auouymous merged 1 commit intogpodder:mastergpodder/gpodder:masterfrom
auouymous merged 1 commit intogpodder:mastergpodder/gpodder:masterfrom
Conversation
Member
|
LGTM, but it would be better if the change was moved up above the dbus section. What part of #922 doesn't it fix? |
Do not perform this check on win32 or osx.
6f473a8 to
8982b4c
Compare
Contributor
Author
Member
|
Merged, thanks. |
Member
|
Thanks @tpikonen and @auouymous 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows running gPodder under pure Wayland.
Doesn't check for these variables under macOS, which will hopefully allow a smaller delta in the OSX version.
Fixes at least some aspects of #922.