Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Replace vfsgen with go:embed #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Replace vfsgen with go:embed #1197

merged 3 commits into from
Jun 11, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Jun 10, 2023

This should make the development process slightly easier, and reduce diff noise a bit.

This may be possible to optimize further, by removing the http.FS wrapper, but that's a bit of a larger change. Perhaps worth looking into separately.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Reference app: jQuery TodoMVC (acf500a6c32a83d8c4582d967b09a65febf0e120)

BRANCH ORIGINAL MINIFIED COMPRESSED (GZIP)
Pull request (embed) 2,883,559 bytes 1,898,781 bytes 381,423 bytes
Target branch (master) 0.00% increase (0 bytes) 0.00% increase (0 bytes) 0.00% increase (0 bytes)

#outputSize

Copy link
Member

@nevkontakte nevkontakte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a fan of this! :)

@flimzy flimzy merged commit 3c090eb into master Jun 11, 2023
@flimzy flimzy deleted the embed branch June 11, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.