Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix jsFS callback-related crashes #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2022
Merged

Fix jsFS callback-related crashes #1118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d54ca66
Fix a crash occurring when a jsFS callback is called without arguments
samhocevar May 11, 2022
ce5430d
Protect against jsFS callback error argument being undefined
samhocevar May 11, 2022
aad4eda
Add a comment to explain fsCall() safety checks
samhocevar May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions 9 compiler/natives/src/syscall/fs_js.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ func fsCall(name string, args ...interface{}) (js.Value, error) {
f := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
var res callResult

if jsErr := args[0]; !jsErr.IsNull() {
res.err = mapJSError(jsErr)
// Check that args has at least one element, then check both IsUndefined() and IsNull() on
// that element. In some situations, BrowserFS calls the callback without arguments or with
// an undefined argument: https://github.com/gopherjs/gopherjs/pull/1118
if len(args) >= 1 {
if jsErr := args[0]; !jsErr.IsUndefined() && !jsErr.IsNull() {
res.err = mapJSError(jsErr)
}
}

res.val = js.Undefined()
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.