Improved build cache invalidation #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
approved these changes
Feb 17, 2022
dad6ef5 to
6dcbb3b
Compare
Previously GopherJS used to store its build cache under $GOPATH/pkg/$GOOS_$GOARCH, and after Go Modules introduction some parts of it were stored under os.UserCacheDir(). Starting from this commit, *all* build cache is located under os.UserCacheDir(), in a manner similar to the modern Go tool. The cache is keyed by a set of build options (such as minification, compiler version, etc.) to ensure that incompatible archives aren't picked up (see gopherjs#440 for example). This change doesn't solve *all* possible cache-related issues (for example, it still relies on timestamps to invalidate the cache, see gopherjs#805), but should eliminate a large class of confusing failure modes.
6dcbb3b to
78745da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously GopherJS used to store its build cache under
$GOPATH/pkg/$GOOS_$GOARCH, and after Go Modules introduction some parts
of it were stored under os.UserCacheDir().
Starting from this commit, all build cache is located under
os.UserCacheDir(), in a manner similar to the modern Go tool. The cache
is keyed by a set of build options (such as minification, compiler
version, etc.) to ensure that incompatible archives aren't picked up
(see #440 for example).
This change doesn't solve all possible cache-related issues (for
example, it still relies on timestamps to invalidate the cache, see
#805), but should eliminate a large class of confusing failure
modes.
Fixes #440, #598, #620