Build package cleanups and minor improvements #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add exported symbol comments golint complains about. - Remove Session.BuildDir, which appears to be unused.
This ensures that all code paths only see adjusted package sources for packages like `os` or `runtime`. This fixes a bug when `gopherjs build runtime` was trying to build the whole runtime package and causing a failure.
This ensures that callers only see imports that actually remain in the sources after we excluded irrelevant parts of the upstream package sources.
flimzy
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several relatively minor refactoring within the
buildpackage, which set the foundation for bigger improvements I'm working on. It includes the following:Since these changes are relatively self-contained and the next change is becoming pretty involved, I decided to split them into a separate pull request for review convenience :)