Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tests: Prefer extension check over environment variable #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

tests: Prefer extension check over environment variable #3381

merged 1 commit into from
May 22, 2025

Conversation

stephenfin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the edit:networking This PR updates networking code label May 14, 2025
@stephenfin
Copy link
Contributor Author

I don't know if these are equivalent. We're going to find out shortly.

@github-actions github-actions bot added the semver:patch No API change label May 14, 2025
@stephenfin stephenfin force-pushed the fip-forwarding-check branch from 081585c to ddb4d48 Compare May 14, 2025 13:39
@coveralls
Copy link

coveralls commented May 14, 2025 •
edited
Loading

Coverage Status

coverage: 63.835% (+0.007%) from 63.828%
when pulling 75cebf6 on shiftstack:fip-forwarding-check
into 0d4b2d4 on gophercloud:main.

@stephenfin
tests: Prefer extension check over environment variable
75cebf6 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin force-pushed the fip-forwarding-check branch from ddb4d48 to 75cebf6 Compare May 16, 2025 11:44
@stephenfin
Copy link
Contributor Author

@kayrus CC

@EmilienM EmilienM merged commit 6f0a5f6 into gophercloud:main May 22, 2025
18 of 19 checks passed
@EmilienM EmilienM deleted the fip-forwarding-check branch May 22, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM EmilienM approved these changes

Assignees
No one assigned
Labels
edit:networking This PR updates networking code semver:patch No API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenfin @coveralls @EmilienM
Morty Proxy This is a proxified and sanitized view of the page, visit original site.