[v2] Use Makefile for CI jobs #3367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more common than the object storage service and allows us to run on a DevStack with default configuration. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit c81a270)
We mangled this, probably since we were renaming the 'imageservice' module to 'image' at the time. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit c56703d)
For use in CI. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit cfeb6d5)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 7f4ed82)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 56b90f6)
We can remove the 'acceptancetest' script in the process. Note that this isn't a 1:1 match: the fwaasv2 test job now runs the entire networking test suite and not just the fwaasv2-specific tests but seeing as this is using OVS rather than OVN that doesn't seem like such a bad thing. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 90cded1)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 641d7c1)
Conflicts: .github/workflows/unit.yaml NOTE(stephenfin): Conflicts are due to trivial spacing. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit c237277)
Users can use 'make unit' for this now. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 5d36693)
We no longer test on Ubuntu 20.04. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 0572399)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 69b5446)
Place service-specific conditions in service-specific locations.
We also removed the now-unused RequireNovaNetwork helper.
Conflicts:
internal/acceptance/openstack/baremetal/httpbasic/portgroups_test.go
NOTE(stephenfin): Conflicts are because the file doesn't exist on the v2
branch (yet)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
(cherry picked from commit 2a22f9d)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 8314ff1)
We already do this for the networking workflow. Now do it for the fwaas-specific workflow. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit df9032a)
Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 148e43a)
We also fix some typos in test names. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit 13997f3)
45478ba to
5fa68ea
Compare
|
@kayrus Think this one is good to go now too. Same failures with the same reasoning as the master version.
|
pierreprinetti
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is manual backport of #3046 combined with #3377, dropping two irrelevant commits and addressing two trivial merge conflicts (called out inline).