-
Notifications
You must be signed in to change notification settings - Fork 553
blockstorage: add manage-existing and unmanage api call #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
blockstorage: add manage-existing and unmanage api call #3332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
cd71982
to
8477643
Compare
Implemented missing blockstorage api call to manage existing volume. ref. https://docs.openstack.org/api-ref/block-storage/v3/#manage-an-existing-volume
Implemented missing blockstorage api call to unmanage volume. ref. https://docs.openstack.org/api-ref/block-storage/v3/#unmanage-a-volume
Added acceptance test for managing a existing volume and unmanaging a volume api calls.
8477643
to
6fb7d11
Compare
Any problems? If there are things to be fixed, I'd like to know. |
There is no problem at all, sorry for the time it takes. The team has been very busy lately. We'll wait to see how CI works here and we'll make a review in a timely manner. |
Thank you for responding! I'm very appreciative for your team's development despite busy schedule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks
Hey @EmilienM would be great if this gets merged, I'm working on something which relies on Cinder Manage. |
Nice to meet you. I always appreciate your developments.
I have this pull request ready to do, so could you please review it?
I implemented a missing blockstorage API call to manage an existing volume and unmanage a volume.
API document for the endpoints are these:
I wrote the unit and acceptance tests and checked that they worked.
Therefore, I tested the new code with the environment and the script below.
And it worked.
Fixes #3324
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
API doc
source code