-
Notifications
You must be signed in to change notification settings - Fork 553
Merge pull request #3209 from shiftstack/proper-service-discovery #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…scovery Configure and respect service type aliases
42cbbca
to
e0b454d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if this PR is flagged as a major change (EndpointOpts: old is comparable, new is not
), I can't imagine it breaking anyone's code, and I'm for having this fix in v2.
I would like to request considering a revert of this because of the regression in #3347. |
The mess was initially introduced by upstream openstack developers, who decided to rename long established service types. Without this fix most of the automatic functional tests against the devstack will be broken. P.S. I agree that this fix looks not quite well, since we could not expect that |
Do you have a link to the relevant upstream change? |
here is one https://gitea10.opendev.org:3081/openstack/manila/commit/27f01aaa7692614c2e72498418a85545a2aed512?style=split&whitespace=show-all&show-outdated= UPD2: openstack/devstack@d7c3c0a the volumev3 endpoint was removed from devstack. |
Configure and respect service type aliases
Fixes #[PUT ISSUE NUMBER HERE]
This is a backport for #3209
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
[PUT URLS HERE]