Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Merge pull request #3209 from shiftstack/proper-service-discovery #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 11, 2025

Configure and respect service type aliases

Fixes #[PUT ISSUE NUMBER HERE]
This is a backport for #3209

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

@github-actions github-actions bot added edit:openstack This PR updates common OpenStack code v2 This PR targets v2 edit:gophercloud This PR updates common Gophercloud code edit:blockstorage This PR updates blockstorage code semver:major Breaking change labels Mar 11, 2025
@coveralls
Copy link

coveralls commented Mar 11, 2025

Coverage Status

coverage: 78.687% (-0.05%) from 78.732%
when pulling e0b454d on kayrus:backport-aliases
into fe8ded1 on gophercloud:v2.

…scovery

Configure and respect service type aliases
@kayrus kayrus force-pushed the backport-aliases branch from 42cbbca to e0b454d Compare March 12, 2025 08:08
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this PR is flagged as a major change (EndpointOpts: old is comparable, new is not), I can't imagine it breaking anyone's code, and I'm for having this fix in v2.

@mandre mandre merged commit 908ce17 into gophercloud:v2 Mar 12, 2025
18 checks passed
@kayrus kayrus deleted the backport-aliases branch March 12, 2025 11:38
@majewsky
Copy link
Contributor

I can't imagine it breaking anyone's code, and I'm for having this fix in v2.

I would like to request considering a revert of this because of the regression in #3347.

@kayrus
Copy link
Contributor Author

kayrus commented Apr 16, 2025

The mess was initially introduced by upstream openstack developers, who decided to rename long established service types. Without this fix most of the automatic functional tests against the devstack will be broken.
You can use a workarond proposed in terraform-provider-openstack/terraform-provider-openstack#1848

P.S. I agree that this fix looks not quite well, since we could not expect that shared-file-system will be an alias to sharev1. But this was a compromise to keep the backward compatibility on the v2 branch. Feel free to suggest a better solution to hunt with the hounds.

@majewsky
Copy link
Contributor

Do you have a link to the relevant upstream change?

@kayrus
Copy link
Contributor Author

kayrus commented Apr 16, 2025

here is one https://gitea10.opendev.org:3081/openstack/manila/commit/27f01aaa7692614c2e72498418a85545a2aed512?style=split&whitespace=show-all&show-outdated=
see also https://specs.openstack.org/openstack/service-types-authority/
UPD: it seems we can set the service aliases in the version descending order. But we need to be sure that the original shared-file-system doesn't lead to the v1 API

UPD2: openstack/devstack@d7c3c0a the volumev3 endpoint was removed from devstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:blockstorage This PR updates blockstorage code edit:gophercloud This PR updates common Gophercloud code edit:openstack This PR updates common OpenStack code semver:major Breaking change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.