Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ci: Fallback to Go 1.22 compatible goimports version #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: Fallback to Go 1.22 compatible goimports version #3323

wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Mar 6, 2025

  • Updated goimports installation to fallback to v0.30.0 if latest requires Go 1.23+.
  • Ensures compatibility with Go 1.22 for Gophercloud v2.
  • Prevents CI failures when running in environments with older Go versions.

This change allows CI and developers using Go 1.22 to continue using goimports without version conflicts.

@EmilienM
ci: Fallback to Go 1.22 compatible goimports version
478a801 
- Updated `goimports` installation to fallback to `v0.30.0` if `latest` requires Go 1.23+.
- Ensures compatibility with Go 1.22 for Gophercloud v2.
- Prevents CI failures when running in environments with older Go versions.

This change allows CI and developers using Go 1.22 to continue using `goimports` without version conflicts.
@EmilienM EmilienM mentioned this pull request Mar 6, 2025
Closed
@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code semver:patch No API change labels Mar 6, 2025
This was referenced Mar 6, 2025
Closed
Closed
@coveralls
Copy link

Coverage Status

coverage: 78.679%. remained the same
when pulling 478a801 on xtools
into 5afeaf8 on main.

@mandre
Copy link
Contributor

mandre commented Mar 7, 2025

Rather than this hack, should instead pin golang.org/x/tools/cmd/goimports to v0.30.0 in our v2 branch if that's the version that supports go 1.22.

@EmilienM
Copy link
Contributor Author

Rather than this hack, should instead pin golang.org/x/tools/cmd/goimports to v0.30.0 in our v2 branch if that's the version that supports go 1.22.

https://github.com/gophercloud/gophercloud/blob/v2/go.mod#L10
isn't it the case already?

@mandre
Copy link
Contributor

mandre commented Mar 10, 2025

Here's my attempt: #3325

@mandre mandre added the hold Do not merge label Mar 10, 2025
@EmilienM EmilienM closed this Mar 10, 2025
@EmilienM EmilienM deleted the xtools branch March 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre Awaiting requested review from mandre

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees
No one assigned
Labels
edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code hold Do not merge semver:patch No API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilienM @coveralls @mandre
Morty Proxy This is a proxified and sanitized view of the page, visit original site.