Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improve support for network standard-attr-* extensions #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Mar 6, 2025

Consistently add support for the neutron Resource revision numbers
extension [1] for more resources that support it. It adds
a RevisionNumber field to all responses, and allows filtering via the
RevisionNumber list option. It was only partially implemented.

Support the If-Match constraints for these resources, and add test for it.

Add a few missing CreatedAt and UpdatedAt fields for networking
resources.

[1] https://docs.openstack.org/api-ref/network/v2/#revisions

@github-actions github-actions bot added edit:networking This PR updates networking code semver:major Breaking change labels Mar 6, 2025
@mandre mandre force-pushed the network-standard-attr branch from 1e9b787 to 5150eb6 Compare March 6, 2025 17:03
mandre added 2 commits March 6, 2025 18:22
Consistently add support for the neutron `Resource revision numbers`
extension [1] for more resources that support it. It adds
a `RevisionNumber` field to all responses, and allows filtering via the
`RevisionNumber` list option. It was only partially implemented.

Also support the `If-Match` constraints, and add test for it.

[1] https://docs.openstack.org/api-ref/network/v2/#revisions
Add a few missing `CreatedAt` and `UpdatedAt` fields for networking
resources.
@mandre mandre force-pushed the network-standard-attr branch from 5150eb6 to 39fc33c Compare March 6, 2025 17:24
@github-actions github-actions bot added semver:minor Backwards-compatible change and removed semver:major Breaking change labels Mar 6, 2025
@mandre mandre changed the title WIP: support network standard-attr-* extensions Improve support for network standard-attr-* extensions Mar 6, 2025
@mandre mandre marked this pull request as ready for review March 6, 2025 17:26
@mandre
Copy link
Contributor Author

mandre commented Mar 6, 2025

I've dropped the non-backward compatible changes as I want to backport this PR. I'll re-add the breaking changes in a new PR once this one merges.

@EmilienM EmilienM added the backport-v2 This PR will be backported to v2 label Mar 6, 2025
@EmilienM EmilienM merged commit 5afeaf8 into gophercloud:main Mar 6, 2025
20 of 21 checks passed
@EmilienM EmilienM deleted the network-standard-attr branch March 6, 2025 18:20
@coveralls
Copy link

coveralls commented Mar 6, 2025

Coverage Status

coverage: 78.679% (-0.08%) from 78.763%
when pulling 39fc33c on shiftstack:network-standard-attr
into 7889e7f on gophercloud:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 This PR will be backported to v2 edit:networking This PR updates networking code semver:minor Backwards-compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.