Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Backport: Added support for hypervisor_hostname to v2 #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

ngin8-beta
Copy link
Contributor

Fixes #3307

@github-actions github-actions bot added edit:compute This PR updates compute code v2 This PR targets v2 semver:minor Backwards-compatible change labels Feb 24, 2025
@EmilienM
Copy link
Contributor

Could you please backport that commit: da9417f instead of the merge commit. Thanks

@coveralls
Copy link

coveralls commented Feb 24, 2025

Coverage Status

coverage: 78.728%. first build
when pulling e47eabd on ngin8-beta:v2
into 2e6154e on gophercloud:v2.

@ngin8-beta
Copy link
Contributor Author

I have tried cherry-picking da9417f as instructed. However, since this is my first time using the cherry-pick feature, I’m not sure if I did it correctly.

@ngin8-beta
Copy link
Contributor Author

❯ git reset --hard HEAD~1

HEAD is now at 2e6154e0 Merge pull request #3299 from shiftstack/prepare_v2.5.0
❯ git status
On branch v2
Your branch is up to date with 'upstream/v2'.

nothing to commit, working tree clean
❯ git cherry-pick da9417f
Auto-merging openstack/compute/v2/servers/requests.go
CONFLICT (content): Merge conflict in openstack/compute/v2/servers/requests.go
Auto-merging openstack/compute/v2/servers/testing/requests_test.go
error: could not apply da9417f3... Added support for hypervisor_hostname
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
❯ git status
On branch v2
Your branch is up to date with 'upstream/v2'.

You are currently cherry-picking commit da9417f3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   openstack/compute/v2/servers/testing/requests_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   openstack/compute/v2/servers/requests.go

❯ vim openstack/compute/v2/servers/requests.go
❯ git add openstack/compute/v2/servers/requests.go
❯ git cherry-pick --continue
[v2 89180c87] Added support for hypervisor_hostname
 Date: Thu Feb 13 10:35:30 2025 +0900
 2 files changed, 28 insertions(+)
❯ git push origin v2 --force
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 24 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.01 KiB | 1.01 MiB/s, done.
Total 9 (delta 7), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (7/7), completed with 7 local objects.
To github.com:ngin8-beta/gophercloud.git
 + 4f7baadc...89180c87 v2 -> v2 (forced update)

@EmilienM
Copy link
Contributor

I resolved the conflict and pushed over your branch.

@ngin8-beta
Copy link
Contributor Author

thx!

@ngin8-beta
Copy link
Contributor Author

failure...😢

@EmilienM
Copy link
Contributor

failure...😢

    volumeattach_test.go:21: Failure in volumeattach_test.go, line 21: unexpected error "No suitable endpoint could be found in the service catalog."

The error is not related.

@mandre are you fine backporting this?

@ngin8-beta
Copy link
Contributor Author

Will the check take a long time?

@EmilienM EmilienM merged commit 654a387 into gophercloud:v2 Mar 1, 2025
17 of 18 checks passed
@ngin8-beta ngin8-beta deleted the v2 branch March 8, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:compute This PR updates compute code semver:minor Backwards-compatible change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.