Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[v2] Address govet 1.24 issue #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

gophercloud-backport-bot[bot]
Copy link

Backport: #3241

Bump golangci-lint, which highlights issues that we will see with go vet 1.24.

Depends-on: #3242

Commits

  • lint: Address recent lint issues
  • lint: Remove non-constant format string in calls (govet)
  • make: Bump golangci-lint

We really need to run golangci-lint in the gate but fix these issues for
now.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We were incorrectly using 'fmt.Printf', 'fmt.Errorf' and 't.Logf' with
non-template strings/no arguments. The fix to this is replace these
calls with the non-suffixed variants. There are many users of
'fmt.Fprint' - too many to do by hand - so this replacement was resolved
using 'sed':

  sed 's/Fprintf/Fprint/g' -i $(ag fmt.Fprintf -l)

We then manually fix the 25 cases where 'fmt.Fprintf' is actually
warranted and manually replaced the errant users of 'fmt.Errorf' and
't.Logf'. We also rework 'internal/acceptance/clients/clients.go'
slightly to make the code a bit clearer.

PS: This is apparently going to be an issue in go 1.24 (specifically in
'go vet') [1] so this is not just golangci-lint being annoying.
@pierreprinetti, that's directed at you ;)

[1] golang/go#60529

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We also add the '-v' and '--max-same-issues' flags so that we get some
indication that things are running and show more output.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@github-actions github-actions bot added edit:networking This PR updates networking code edit:openstack This PR updates common OpenStack code edit:dns This PR updates dns code edit:common This PR updates common code edit:image This PR updates image code edit:orchestration This PR updates orchestration code edit:loadbalancer This PR updates loadbalancer code edit:compute This PR updates compute code edit:keymanager This PR updates keymanager code v2 This PR targets v2 edit:messaging This PR updates messaging code edit:containerinfra This PR updates containerinfra code edit:placement This PR updates placement code edit:objectstorage This PR updates objectstorage code edit:workflow This PR updates workflow code edit:sharedfilesystems This PR updates sharedfilesystems code edit:baremetal This PR updates baremetal code edit:gophercloud This PR updates common Gophercloud code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code edit:container This PR updates container code edit:baremetalintrospection This PR updates baremetalintrospection code edit:testinfra This PR updates testing infrastructure code labels Dec 6, 2024
@github-actions github-actions bot added the semver:patch No API change label Dec 6, 2024
@pierreprinetti pierreprinetti merged commit 1dccc8d into v2 Dec 6, 2024
83 of 87 checks passed
@pierreprinetti pierreprinetti deleted the bp-v2-eaf2923-ce56d12-0d4b68d branch December 6, 2024 09:53
@coveralls
Copy link

Coverage Status

coverage: 78.721%. remained the same
when pulling 752f35e on bp-v2-eaf2923-ce56d12-0d4b68d
into b8089e5 on v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit:baremetal This PR updates baremetal code edit:baremetalintrospection This PR updates baremetalintrospection code edit:blockstorage This PR updates blockstorage code edit:common This PR updates common code edit:compute This PR updates compute code edit:container This PR updates container code edit:containerinfra This PR updates containerinfra code edit:dns This PR updates dns code edit:gophercloud This PR updates common Gophercloud code edit:identity This PR updates identity code edit:image This PR updates image code edit:keymanager This PR updates keymanager code edit:loadbalancer This PR updates loadbalancer code edit:messaging This PR updates messaging code edit:networking This PR updates networking code edit:objectstorage This PR updates objectstorage code edit:openstack This PR updates common OpenStack code edit:orchestration This PR updates orchestration code edit:placement This PR updates placement code edit:sharedfilesystems This PR updates sharedfilesystems code edit:testinfra This PR updates testing infrastructure code edit:workflow This PR updates workflow code semver:patch No API change v2 This PR targets v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.