[v2] Misc cleanups #3261
Merged
[v2] Misc cleanups #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is not referenced or documented anywhere and it has not been touched in years. Remove it. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
testhelper is too long give how often these things are used. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Better errors messages since we see the different types. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Make this a little easier to understand failures when they occur. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We were not passing through user IDs, despite our test wrappers indicating you could user either user IDs or usernames. Similarly, we were not always setting scope, which could cause issues when using a project ID. Correct all issues. We should eventually move this to another test helper but that's a job for a later change. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We're clearly not testing with non-admin credentials. That would be a good future test but for now we simply fix the issues. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Setting the necessary required environment variables has proven relatively tricky to do. Add a tool that will start doing this for us. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
pierreprinetti
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #3065
A couple of somewhat generally "CI-related" changes that I'm too lazy to propose as separate PRs.
make: Add 'format' targetscript: Remove unused bootstrap scripttrivial: Consistent file extensionsscript: Address shellcheck warningstests: Consist use of th aliastests: Add AssertTypeOf helpertesting: Set test case namestests: Be consistent in our generation of credentialstests: Add missing RequireAdmin callsscripts: Add getenvvar tool