[manila] add share_group_id to share's CreateOpts #3205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilienM
previously approved these changes
Oct 9, 2024
|
@EmilienM can you approve this? |
d0050f9 to
f8007ee
Compare
|
@pierreprinetti @mdbooth @EmilienM kindly ping |
mdbooth
reviewed
Oct 16, 2024
| @@ -40,6 +40,8 @@ type CreateOpts struct { | ||
| SnapshotID string `json:"snapshot_id,omitempty"` | ||
| // Determines whether or not the share is public | ||
| IsPublic *bool `json:"is_public,omitempty"` | ||
| // The UUID of the share group. Available starting from the microversion 2.31 | ||
| ShareGroupID string `json:"share_group_id,omitempty"` |
There was a problem hiding this comment.
| @@ -54,6 +54,8 @@ type Share struct { | ||
| ShareType string `json:"share_type"` | ||
| // The name of the share type. | ||
| ShareTypeName string `json:"share_type_name"` | ||
| // The UUID of the share group. Available starting from the microversion 2.31 | ||
| ShareGroupID string `json:"share_group_id"` |
There was a problem hiding this comment.
in order to have tests we need to implement a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes the #3204