Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adjust List func to accept a Builder in tenants, routers and security groups packages #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

Adjust List func to accept a Builder in tenants, routers and security groups packages #3097

wants to merge 1 commit into from
+31 −13

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jul 10, 2024

Prior to starting a PR, please make sure you have read our
contributor tutorial.

Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.

Fixes #[PUT ISSUE NUMBER HERE]

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

This is a foillow-up for the #3070

@kayrus kayrus requested a review from pierreprinetti July 10, 2024 14:33
@github-actions github-actions bot added the semver:major Breaking change label Jul 10, 2024
@coveralls
Copy link

coveralls commented Jul 10, 2024 •
edited
Loading

Coverage Status

coverage: 63.827% (-0.003%) from 63.83%
when pulling 5d0eefd on kayrus:secgroup_listoptsbuilder
into ad0459b on gophercloud:main.

@kayrus kayrus marked this pull request as draft July 10, 2024 14:46
@kayrus kayrus marked this pull request as ready for review July 11, 2024 06:41
@kayrus kayrus requested a review from a team July 17, 2024 12:00
@pierreprinetti
Copy link
Member

@kayrus Do you want to look around in case there are more like this across the codebase?

@kayrus
Copy link
Contributor Author

kayrus commented Jul 17, 2024

@pierreprinetti

$ grep -r 'func List(' | grep -i opts | grep -v Builder
openstack/identity/v2/tenants/requests.go:func List(client *gophercloud.ServiceClient, opts *ListOpts) pagination.Pager {
openstack/networking/v2/extensions/layer3/routers/requests.go:func List(c *gophercloud.ServiceClient, opts ListOpts) pagination.Pager {
openstack/networking/v2/extensions/security/rules/requests.go:func List(c *gophercloud.ServiceClient, opts ListOpts) pagination.Pager {

shall I add a Builder to these packages within this PR?

@pierreprinetti
Copy link
Member

shall I add a Builder to these packages within this PR?

I think it would be nice. What do you think?

@kayrus
Copy link
Contributor Author

kayrus commented Jul 17, 2024

will do then

@kayrus kayrus force-pushed the secgroup_listoptsbuilder branch from 8f342a3 to c94bb25 Compare July 17, 2024 14:45
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Jul 17, 2024
@kayrus kayrus force-pushed the secgroup_listoptsbuilder branch from c94bb25 to f3f8548 Compare July 17, 2024 14:50
@kayrus kayrus changed the title networks: Security groups rules List to accept a Builder Adjust List func to accept a Builder in tenants, routers and security groups packages Jul 17, 2024
@github-actions github-actions bot added semver:major Breaking change and removed semver:major Breaking change labels Jul 17, 2024
@pierreprinetti pierreprinetti self-assigned this Sep 26, 2024
@kayrus kayrus force-pushed the secgroup_listoptsbuilder branch from f3f8548 to e752cb3 Compare May 23, 2025 13:32
@github-actions github-actions bot added edit:networking This PR updates networking code edit:dns This PR updates dns code edit:image This PR updates image code edit:orchestration This PR updates orchestration code edit:loadbalancer This PR updates loadbalancer code edit:compute This PR updates compute code edit:keymanager This PR updates keymanager code edit:messaging This PR updates messaging code edit:containerinfra This PR updates containerinfra code edit:placement This PR updates placement code edit:objectstorage This PR updates objectstorage code labels May 23, 2025
@github-actions github-actions bot added edit:sharedfilesystems This PR updates sharedfilesystems code edit:baremetal This PR updates baremetal code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code edit:container This PR updates container code edit:baremetalintrospection This PR updates baremetalintrospection code labels May 23, 2025
@kayrus kayrus force-pushed the secgroup_listoptsbuilder branch from e752cb3 to 5a194eb Compare May 23, 2025 13:35
@kayrus kayrus added the backport-v2 This PR will be backported to v2 label May 23, 2025
@kayrus kayrus force-pushed the secgroup_listoptsbuilder branch from 5a194eb to 5d0eefd Compare May 23, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

At least 1 approving review is required to merge this pull request.

Assignees

@pierreprinetti pierreprinetti

Labels
backport-v2 This PR will be backported to v2 edit:baremetal This PR updates baremetal code edit:baremetalintrospection This PR updates baremetalintrospection code edit:blockstorage This PR updates blockstorage code edit:compute This PR updates compute code edit:container This PR updates container code edit:containerinfra This PR updates containerinfra code edit:dns This PR updates dns code edit:identity This PR updates identity code edit:image This PR updates image code edit:keymanager This PR updates keymanager code edit:loadbalancer This PR updates loadbalancer code edit:messaging This PR updates messaging code edit:networking This PR updates networking code edit:objectstorage This PR updates objectstorage code edit:orchestration This PR updates orchestration code edit:placement This PR updates placement code edit:sharedfilesystems This PR updates sharedfilesystems code semver:major Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayrus @coveralls @pierreprinetti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.