Add UpdatedAt to ports.Port #2445
Conversation
All neutron core resources have created_at and updated_at, see [class Timestamp](https://github.com/openstack/neutron/blob/b7fad3dd35ad23303a5f52ec64478860a137775e/neutron/extensions/timestamp.py#L33). Signed-off-by: Matt Vinall <boyvinall@gmail.com>
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
There was a problem hiding this comment.
This looks good.
While looking at the Network resource, it looks like neutron used to use a different time format and we extra steps when unmarshalling the JSON response, as seen in #1670. However, the linked PR from Aug 2019 mentions "older" openstack version. At the time, Train was still the development version (released on 2019-10-16), and is now the oldest version we support in gophercloud. We should be fine with your change.
However, while you're at it, updated_at comes in pair with created_at, would you mind adding it also?
Signed-off-by: Matt Vinall <boyvinall@gmail.com>
|
Sure, added that now, thanks. |
Fixes #2444
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: