Do not install tempest in sharedfilesystems jobs #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE` defaults to true in manila's devstack plugin [1], we're getting tempest plugin. This is problematic for us because: - we don't want to spend extra time installing unneeded dependencies - this makes it more likely to break, as shown with gophercloud#2440. This commit sets `MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE` to false in the Share Filesystems job. Fixes gophercloud#2440. [1] https://opendev.org/openstack/manila/src/commit/205d716/devstack/settings#L208
pierreprinetti
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDEdefaults to true inmanila's devstack plugin [1], we're getting tempest plugin. This is
problematic for us because:
This commit sets
MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDEto false inthe Share Filesystems job.
Fixes #2440.
[1] https://opendev.org/openstack/manila/src/commit/205d716/devstack/settings#L208