Adjusted Blockstorage V3 Snapshot List Endpoint #2404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the normal list snapshots with the detailed list endpoint url.
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
Adjusted the unit tests to provide the /snapshots/detail endpoint for listing snapshots
mandre
requested changes
May 20, 2022
There was a problem hiding this comment.
These are two different API calls, both valid:
- list snapshots on
/v3/{project_id}/snapshots - list snapshots and details on
/v3/{project_id}/snapshots/detail
In consequence, we should create a new function (ListDetail()?) in /v3/snapshots/requests.go for the new /v3/{project_id}/snapshots/detail endpoint, rather than updating the List() function to return the detailed list of snapshots.
|
Superseded by #3305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the normal list snapshots with the detailed list endpoint url.
Fixes #2403
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=list-accessible-snapshots-detail,list-snapshots-and-details-detail#list-snapshots-and-details