-
Notifications
You must be signed in to change notification settings - Fork 553
Add missing fields in Objectstorage and compute API #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
bonjour @pdesgarets :-) Thanks for your pull request. For this PR, I see it has unit tests, thanks. It'll be great to also have acceptance coverage. Let me know if you need help for that. Thanks! |
OK, thanks for the review, I'll try to add acceptance tests, that may require some additional time |
Hello, may I ask if you are willing to further improve this PR? Now I have some requirements for Server Lock Status @pdesgarets |
Hi, I currently lack of free time, feel free to start from by branch and add the needed acceptance tests |
f8b21a4
to
cec507c
Compare
Fixes #2386 and #1958
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/compute/?expanded=show-server-details-detail#:~:text=security%20group%20name.-,locked,-body
https://docs.openstack.org/api-ref/object-store/?expanded=create-container-detail#:~:text=X%2DContainer%2DSync%2DTo%20(Optional)