Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 844b059

Browse filesBrowse files
committed
CI: Fix SkipRelease for stable branches
Since 5819dc0, `getReleaseFromEnv()` trims the `stable/` prefix, which caused the condition in `SkipRelease()` to fail if we looked for a release name including the prefix. Fix `SkipRelease()` to account for release names with a `stable/` prefix.
1 parent d355163 commit 844b059
Copy full SHA for 844b059

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎internal/acceptance/clients/conditions.go

Copy file name to clipboardExpand all lines: internal/acceptance/clients/conditions.go
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func getReleaseFromEnv(t *testing.T) string {
119119
// release. Releases are named such as 'stable/mitaka', master, etc.
120120
func SkipRelease(t *testing.T, release string) {
121121
current := getReleaseFromEnv(t)
122-
if current == release {
122+
if current == strings.TrimPrefix(release, "stable/") {
123123
t.Skipf("this is not supported in %s", release)
124124
}
125125
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.