feat(storage): add async credential wrapper#1659
feat(storage): add async credential wrapper#1659googlyrahman merged 2 commits intogoogleapis:asyncgoogleapis/python-storage:asyncfrom
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a practical solution for integrating existing synchronous Google Auth credentials into asynchronous Python applications. By wrapping the synchronous credentials with an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an AsyncCredsWrapper to adapt synchronous Google Auth credentials for asynchronous use. The approach of using run_in_executor for blocking calls is sound. My review includes a few suggestions to improve the implementation:
- The
__init__method should be updated to callsuper().__init__()and use the modernasyncio.get_running_loop()instead of the deprecatedget_event_loop(). - The wrapper should delegate property access (e.g.,
valid,token) to the wrapped credentials object to ensure it behaves as a transparent proxy and provides correct state information. - A minor simplification in the
before_requestmethod is also suggested.
These changes will make the wrapper more robust, correct, and easier to use.
b414a10 to
36e73ba
Compare
| return self.creds.valid | ||
|
|
||
| async def before_request(self, _request, method, url, headers): | ||
| """Performs credential-specific before request logic.""" |
There was a problem hiding this comment.
nit: sentence's meaning is not coming out clearly.
36e73ba to
8d2b219
Compare
8d2b219 to
8ed4ca8
Compare
Adds async credential wrapper for async client. Context: - The standard google auth credentials are currently synchronous, and it's asynchronous credentials classes are either not available or marked private. - Credential retrieval and refreshing will remain synchronous under the hood. Rationale: As authentication tokens typically possess an expiration lifetime of one hour, the blocking time required for token fetching occurs infrequently. The performance impact of blocking (or utilizing a separate thread for offloading) once per hour is deemed negligible when weighed against the considerable engineering cost of developing and maintaining a asynchronous authentication.
Adds async credential wrapper for async client.
Context: