Commit 2ef6339
authored
fix: receive eof while closing reads stream (#1733)
When `writer.close()` is called without setting finalize_on_close flag,
we need to get two responses:
1) to get the persisted_size
2) eof response
That's why added a check if the first response is not eof, then again
receive the response from the stream.1 parent c8dd7a0 commit 2ef6339Copy full SHA for 2ef6339
File tree
Expand file treeCollapse file tree
2 files changed
+59
-2
lines changedOpen diff view settings
Filter options
- google/cloud/storage/asyncio
- tests/unit/asyncio
Expand file treeCollapse file tree
2 files changed
+59
-2
lines changedOpen diff view settings
Collapse file
google/cloud/storage/asyncio/async_write_object_stream.py
Copy file name to clipboardExpand all lines: google/cloud/storage/asyncio/async_write_object_stream.py+11-2Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
13 | 13 | |
14 | 14 | |
15 | 15 | |
| 16 | + |
16 | 17 | |
17 | 18 | |
18 | 19 | |
| ||
181 | 182 | |
182 | 183 | |
183 | 184 | |
184 | | - |
185 | 185 | |
186 | | - |
| 186 | + |
| 187 | + |
| 188 | + |
| 189 | + |
| 190 | + |
| 191 | + |
| 192 | + |
| 193 | + |
| 194 | + |
| 195 | + |
187 | 196 | |
188 | 197 | |
189 | 198 | |
|
Collapse file
tests/unit/asyncio/test_async_write_object_stream.py
Copy file name to clipboardExpand all lines: tests/unit/asyncio/test_async_write_object_stream.py+48Lines changed: 48 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
15 | 15 | |
16 | 16 | |
17 | 17 | |
| 18 | + |
| 19 | + |
18 | 20 | |
19 | 21 | |
20 | 22 | |
| ||
194 | 196 | |
195 | 197 | |
196 | 198 | |
| 199 | + |
| 200 | + |
| 201 | + |
| 202 | + |
197 | 203 | |
198 | 204 | |
199 | 205 | |
200 | 206 | |
201 | 207 | |
| 208 | + |
| 209 | + |
| 210 | + |
| 211 | + |
| 212 | + |
| 213 | + |
| 214 | + |
| 215 | + |
| 216 | + |
| 217 | + |
| 218 | + |
| 219 | + |
| 220 | + |
| 221 | + |
| 222 | + |
| 223 | + |
| 224 | + |
| 225 | + |
| 226 | + |
| 227 | + |
| 228 | + |
| 229 | + |
| 230 | + |
| 231 | + |
| 232 | + |
| 233 | + |
| 234 | + |
| 235 | + |
| 236 | + |
| 237 | + |
| 238 | + |
| 239 | + |
| 240 | + |
| 241 | + |
| 242 | + |
| 243 | + |
| 244 | + |
| 245 | + |
| 246 | + |
| 247 | + |
| 248 | + |
| 249 | + |
202 | 250 | |
203 | 251 | |
204 | 252 | |
|
0 commit comments